feat(Badge): add square prop#4008
Merged
benjamincanac merged 5 commits intonuxt:v3from May 13, 2025
zAlweNy26:feat/square-badge
Merged
feat(Badge): add square prop#4008benjamincanac merged 5 commits intonuxt:v3from zAlweNy26:feat/square-badge
square prop#4008benjamincanac merged 5 commits intonuxt:v3from
zAlweNy26:feat/square-badge
Conversation
Contributor
Author
|
@benjamincanac sorry but where am I missing the type definition? |
commit: |
| }, | ||
| md: { | ||
| base: 'text-xs px-2 py-1 gap-1 rounded-md', | ||
| base: 'text-xs px-2 py-1.5 gap-1 rounded-md', |
Member
There was a problem hiding this comment.
Why did you change the theme here? 🤔
Contributor
Author
There was a problem hiding this comment.
@benjamincanac I did that to have different sizes when the badge is square. But maybe it's better to match the x padding instead of the y ?
Member
There was a problem hiding this comment.
The square variant should apply p-1 on md size in this case.
Contributor
Author
There was a problem hiding this comment.
@benjamincanac sorry I don't understand why, do you want me to reset the size variants to the original values and let the square variant match the y padding?
Member
There was a problem hiding this comment.
Yes exactly, we shouldn't change the default values.
benjamincanac
changed the title
square prop
benjamincanac
approved these changes
May 13, 2025
Member
|
Thanks 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #4006
❓ Type of change
📚 Description
As said in the linked issue, it would facilitate the use of the
Badgecomponent when you use only theiconprop without any label.📝 Checklist